-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Mpsl alt #25756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Mpsl alt #25756
Conversation
|
Since quarantine was modified, please make sure you are following the process described in Quarantine Process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR integrates major updates from upstream nrfx library (PR-1834 for test_rs, test_fem, and PR-896 for test_crypto), introducing significant API changes and modernizations across the Nordic SDK codebase.
Key Changes:
- Migration from nrfx instance-specific APIs to generic driver APIs (TIMER, UARTE, TWIS, GPIOTE, GPPI)
- Error handling updated from NRFX_SUCCESS/nrfx_err_t to errno-based return codes (0/-errno)
- GPPI (Generic PPI) API overhaul replacing individual PPI/DPPI channel management
- Include path changes (nrf.h → nrfx.h, soc/nrfx_coredep.h → lib/nrfx_coredep.h)
- Removal of instance-specific Kconfig options in favor of generic driver enables
- GPIOTE instance handling changes from const to pointer-based
Reviewed changes
Copilot reviewed 205 out of 205 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| west.yml | Updates dependency revisions to pull/head branches for zephyr, mcuboot, nrfxlib, and trusted-firmware-m |
| tests/**/*.conf | Removes instance-specific driver configs (CONFIG_NRFX_TIMER0, CONFIG_NRFX_TWIS22, etc.) in favor of generic CONFIG_NRFX_TIMER, CONFIG_NRFX_TWIS |
| tests/**/*.c | Updates nrfx API usage: timer instances, GPPI connections, GPIOTE handling, error code checks, TWIS/NVMC function signatures |
| subsys/mpsl/** | Major GPPI API refactoring for PPI/DPPI channel allocation and endpoint management across pin debug, FEM, and coexistence modules |
| subsys/nfc/lib/platform.c | Converts nfc_platform functions from nrfx_err_t to int return types with errno codes |
| subsys/esb/** | Updates ESB to use new GPPI domain connection APIs and generic timer instances |
| subsys/debug/** | Refactors PPI trace and CPU load to use new GPPI connection allocation APIs |
| subsys/nrf_security/** | Updates include paths from nrf.h to nrfx.h and soc/nrfx_coredep.h to lib/nrfx_coredep.h |
| subsys/gazell/** | Migrates from nrfx_ppi to nrfx_gppi_domain_conn APIs |
| samples/bluetooth/** | Updates BLE samples with new GPPI/GPIOTE APIs, timer instances, and GRTC syscounter changes |
| samples/peripheral/** | Radio test, 802.15.4 PHY test, and LPUART samples updated for new timer/GPPI/GPIOTE patterns |
| modules/nrfxlib/** | Updates 802.15.4 platform code for new GPPI cross-domain connection APIs on nRF54L |
| lib/** | Updates library code (ram_pwrdn, nrf_modem_lib, hw_unique_key, fprotect) for new include paths and API patterns |
| soc/nordic/nrf71/soc.c | Updates include paths and removes obsolete system header includes |
| soc/nordic/nrf54l/Kconfig | Adds CPU_HAS_ARM_MPU selection for nRF54LS05B |
| scripts/quarantine*.yaml | Adds quarantine entries for incompatible test scenarios |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
The following west manifest projects have changed revision in this Pull Request: ⛔ DNM label due to: 5 projects with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, click the 'edited' button above Inputs:Sources:hal_nordic: PR head: b2188cee29a564b2655a9dccea87dd7bcb3e2a69 more detailshal_nordic:
nrf_hw_models:
trusted-firmware-m:
sdk-nrf:
mcuboot:
nrfxlib:
zephyr:
Github labels
List of changed files detected by CI (1412)Outputs:ToolchainVersion: 4e36fbc961 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
0ef0550 to
a8e96b5
Compare
Memory footprint analysis revealed the following potential issuesapplications.hpf.gpio.icbmsg[nrf54l15dk/nrf54l15/cpuflpr]: High RAM usage: 12744[B] - link (cc: @nrfconnect/ncs-ll-ursus) Note: This message is automatically posted and updated by the CI (latest/sdk-nrf/PR-25756/9) |
a8e96b5 to
1a19d1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 205 out of 205 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Update sdk-zephyr with collab-nrfx-4.0 merged to main branch. Update nrfxlib with major rework of GPPI library. Manifest sdk-mcuboot updated to nrfx_wdt changes. TF-M: platform: nordic_nrf: align to nrfx 4.0 Signed-off-by: Jakub Zymelka <[email protected]>
Enabled workaround for MLTPAN-60 anomaly in NFC platform. Ref: NCSDK-31244 Signed-off-by: Marcin Jelinski <[email protected]>
Make MDK path dependent on BSP path, since it is now located there. Signed-off-by: Magdalena Pastula <[email protected]>
Remove selecting PRS BOX other than PRS_BOX_0, as it now causes compilation errors due to not checking if `NRFX_PRS_BOX_*_ADDR` is defined in nrfx driver. Signed-off-by: Magdalena Pastula <[email protected]>
NRF_POWER_RAMPOWER_S0POWER is deprecated and is to be removed soon. Signed-off-by: Michał Stasiak <[email protected]>
Will be fixed in NRFX-8421. Signed-off-by: Magdalena Pastula <[email protected]>
Added prescaler substructure to I2S configuration. Signed-off-by: Michał Stasiak <[email protected]>
Switch saadc pin definitions for generic ones defined in nrf-saadc.h Signed-off-by: Jakub Zymelka <[email protected]>
GPIOTE driver instances are no longer defined within nrfx. Signed-off-by: Nikodem Kastelik <[email protected]>
GPIOTE driver instances are no longer defined within nrfx. Signed-off-by: Nikodem Kastelik <[email protected]>
GPIOTE driver instances are no longer defined within nrfx. Signed-off-by: Nikodem Kastelik <[email protected]>
GPIOTE driver instances are no longer defined within nrfx. Signed-off-by: Nikodem Kastelik <[email protected]>
Errno codes are returned now. Signed-off-by: Nikodem Kastelik <[email protected]>
Errno codes are returned now. Signed-off-by: Nikodem Kastelik <[email protected]>
GPIOTE instance shall be accessed via pointer. Signed-off-by: Nikodem Kastelik <[email protected]>
Those are no longer static inlines in the header, so should be implemented separately. Signed-off-by: Marcin Szymczyk <[email protected]>
Updated error codes for nrfx_clock and attached nrfx and zephyr revisions. Signed-off-by: Michal Frankiewicz <[email protected]>
nrfx_err_t is to be removed from nrfx completely. Signed-off-by: Michał Stasiak <[email protected]>
NRFX RTC driver now returns errno values. Signed-off-by: Michał Stasiak <[email protected]>
NRFX NVMC driver now returns errno values. Signed-off-by: Michał Stasiak <[email protected]>
There are minor updates in GPPI API. Align in places that are affected. Signed-off-by: Krzysztof Chruściński <[email protected]>
Align test to extracted control block in nrfx_timer and nrfx_gpiote drivers. Signed-off-by: Jakub Zymelka <[email protected]>
Since nrfx driver instances are no longer exposed in Kconfig, DT should be used to assert instances will not be used by both MPSL and application. Signed-off-by: Marcin Szymczyk <[email protected]>
nrfx functions now return errno.h values. Signed-off-by: Marcin Szymczyk <[email protected]>
Align to new return codes. Signed-off-by: Marcin Szymczyk <[email protected]>
Rework implementation of local domain and cross domain connections setup. Local domain connections happens frequent from an interrupt context so need to be fast. Signed-off-by: Krzysztof Chruściński <[email protected]>
nrfx uses errno now. Signed-off-by: Marcin Szymczyk <[email protected]>
Temporary update to test CI. Signed-off-by: Marcin Szymczyk <[email protected]>
This reverts commit 8ee33a22cadc7e405e8055b0564c4f9a65ae4090.
This reverts commit ab754742e5ecce54dd4fadcf2ef07aa0c933adfb.
This reverts commit 63e54645a7fd849aa33981aa26e88a1d5545a736.
nrfx_dppi is deprecated and gppi shall be used. Signed-off-by: Krzysztof Chruściński <[email protected]>
There are minor updates in GPPI API. Align in places that are affected. Signed-off-by: Krzysztof Chruściński <[email protected]>
1a19d1d to
00cb7d3
Compare
|
You can find the documentation preview for this PR here. Preview links for modified nRF Connect SDK documents: https://ncsdoc.z6.web.core.windows.net/PR-25756/nrf/samples/nrf5340/empty_app_core/README.html |
test_rs: PR-1834
test_fem: PR-1834
test_crypto: PR-896